fix(connectors): connectors polish bundle (#1043) - #1080

app/src/components/widget-editor/widget-preview-panel.tsx (1)

168-182: 💤 Low value

Error mapping logic is correct; IIFE is slightly less readable.

The code correctly maps preview errors via mapPreviewError, displays "Writes not allowed" for blocked-write attempts, and falls back to "Query failed" with the raw message otherwise. Optional chaining on line 170 safely handles null errors.

The IIFE pattern works but extracting writeMsg before the return (e.g., const writeMsg = mapPreviewError(previewQuery.error?.message);) would be marginally clearer. Not a blocker.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/components/widget-editor/widget-preview-panel.tsx` around lines 168 -
182, Extract the IIFE result into a local variable for clarity: call
mapPreviewError(previewQuery.error?.message) once at the top of the component
(e.g., const writeMsg = mapPreviewError(previewQuery.error?.message);) and then
replace the immediately-invoked function expression with the JSX that uses
writeMsg (the AlertCircle block that shows the title {writeMsg ? "Writes not
allowed" : "Query failed"} and the message {writeMsg ??
previewQuery.error?.message}). This preserves the existing logic and optional
chaining but removes the IIFE for improved readability.

app/src/lib/query/preview-error.ts (2)

32-38: ⚡ Quick win

The phrase "cannot execute" might be too broad and could match non-write errors.

Line 37 includes "cannot execute" to catch PostgreSQL read-only transaction errors like "cannot execute DELETE in a read-only transaction" (verified by the test on line 31). However, this phrase is generic and could match unrelated errors such as "cannot execute query: connection timeout" or "cannot execute query due to insufficient permissions", incorrectly mapping them to the write-not-allowed message.

If false positives become an issue, consider narrowing the phrase to "in a read-only transaction" or matching the full pattern "cannot execute .* in a read-only transaction".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/lib/query/preview-error.ts` around lines 32 - 38, The
READ_ONLY_PHRASES entry "cannot execute" is too broad and causes false
positives; narrow it to target read-only transaction messages by replacing that
entry with either the specific substring "in a read-only transaction" or a regex
pattern like "cannot execute .* in a read-only transaction" and update the
lookup logic that matches READ_ONLY_PHRASES (wherever READ_ONLY_PHRASES is used)
to support regex matching if you choose the pattern approach so only messages
explicitly about read-only transactions are caught.

---

19-30: 💤 Low value

Trailing spaces on "set " and "remove " are trimmed away and provide no precision benefit.

Lines 28-29 include trailing spaces on "set " and "remove ", likely to avoid false matches. However, the regex on line 42 captures [a-z]+ (no spaces), and line 44 applies .trim() to each keyword before comparison, so the trailing spaces are discarded. The intent might have been to distinguish SET (session config) from data writes, but the trim removes that distinction.

Additionally, SET in PostgreSQL is typically a session-level command (SET search_path = ...), not a data write. Wrapping it triggers a syntax error, but mapping it to "Writes aren't allowed" could be misleading since it's config, not data mutation.

Consider either removing the trailing spaces for clarity or being more specific about which SET/REMOVE patterns constitute writes.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/lib/query/preview-error.ts` around lines 19 - 30, The WRITE_KEYWORDS
array contains entries "set " and "remove " whose trailing spaces are discarded
by the existing regex capture ([a-z]+) and the subsequent .trim(), so remove the
trailing spaces and make the match precise: update WRITE_KEYWORDS to use "set"
and "remove" (no trailing spaces) and tighten the keyword extraction regex to
use word boundaries (e.g., \b([a-z]+)\b) so keywords are matched as whole words;
leave the existing .trim() in place or remove it if you rely on the
word-boundary regex.

app/src/lib/query/__tests__/preview-error.test.ts (1)

7-47: ⚡ Quick win

Test coverage is solid for the main cases.

The suite covers the primary scenarios: PostgreSQL wrapped-write syntax errors (DELETE/UPDATE/INSERT), Neo4j read-access violations, PostgreSQL read-only transaction errors, and appropriate null returns for non-write and empty inputs.

For completeness, consider adding assertions for the other WRITE_KEYWORDS (MERGE, CREATE, DROP, ALTER, TRUNCATE, SET, REMOVE) and READ_ONLY_PHRASES ("write operations are not allowed", "read-only transaction", "read only transaction"). Not critical since the logic is straightforward, but broader coverage would guard against future regressions.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/lib/query/__tests__/preview-error.test.ts` around lines 7 - 47, Add
tests to preview-error.test.ts to assert that mapPreviewError returns
PREVIEW_WRITE_NOT_ALLOWED_MESSAGE for the remaining WRITE_KEYWORDS (MERGE,
CREATE, DROP, ALTER, TRUNCATE, SET, REMOVE) and for additional read-only phrases
from READ_ONLY_PHRASES such as "write operations are not allowed", "read-only
transaction", and "read only transaction"; keep using the same test style as
existing cases (call mapPreviewError with the phrase and expect
PREVIEW_WRITE_NOT_ALLOWED_MESSAGE) and reference the existing symbols
mapPreviewError and PREVIEW_WRITE_NOT_ALLOWED_MESSAGE so the test suite covers
these extra inputs.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes